This repository was archived by the owner on Jan 7, 2025. It is now read-only.
feat(core/df-repr): better upper bound pruning to reduce plan space #265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skyzh
added a commit
that referenced
this pull request
Dec 18, 2024
Signed-off-by: Alex Chi Z <[email protected]>
skyzh
force-pushed
the
skyzh/plan-join-perf
branch
from
b3288bc to
7fef116
Compare
skyzh
added a commit
that referenced
this pull request
Dec 18, 2024
Signed-off-by: Alex Chi Z <[email protected]> tune plan space budget Signed-off-by: Alex Chi Z <[email protected]>
skyzh
added a commit
that referenced
this pull request
Dec 18, 2024
Signed-off-by: Alex Chi Z <[email protected]>
skyzh
force-pushed
the
skyzh/plan-join-perf
branch
from
7fef116 to
b3cff3c
Compare
skyzh
added a commit
that referenced
this pull request
Dec 18, 2024
Signed-off-by: Alex Chi Z <[email protected]>
skyzh
added a commit
that referenced
this pull request
Dec 18, 2024
Signed-off-by: Alex Chi Z <[email protected]>
skyzh
added a commit
that referenced
this pull request
Dec 18, 2024
Signed-off-by: Alex Chi Z <[email protected]>
skyzh
force-pushed
the
skyzh/plan-join-perf
branch
from
b3cff3c to
fc187cf
Compare
skyzh
added a commit
that referenced
this pull request
Dec 18, 2024
Signed-off-by: Alex Chi Z <[email protected]>
skyzh
force-pushed
the
skyzh/plan-join-perf
branch
from
f225728 to
cac5d3f
Compare
skyzh
added a commit
that referenced
this pull request
Dec 18, 2024
Signed-off-by: Alex Chi Z <[email protected]>
skyzh
added a commit
that referenced
this pull request
Dec 18, 2024
Signed-off-by: Alex Chi Z <[email protected]>
skyzh
force-pushed
the
skyzh/plan-join-perf
branch
from
bf25604 to
7f7c84d
Compare
skyzh
added a commit
that referenced
this pull request
Dec 18, 2024
Signed-off-by: Alex Chi Z <[email protected]>
skyzh
force-pushed
the
skyzh/plan-join-perf
branch
from
7f7c84d to
5325531
Compare
skyzh
added a commit
that referenced
this pull request
Dec 18, 2024
Signed-off-by: Alex Chi Z <[email protected]>
skyzh
added a commit
that referenced
this pull request
Dec 18, 2024
Signed-off-by: Alex Chi Z <[email protected]> tune plan space budget Signed-off-by: Alex Chi Z <[email protected]>
skyzh
added a commit
that referenced
this pull request
Dec 18, 2024
Signed-off-by: Alex Chi Z <[email protected]>
skyzh
added a commit
that referenced
this pull request
Dec 18, 2024
Signed-off-by: Alex Chi Z <[email protected]>
skyzh
force-pushed
the
skyzh/plan-join-perf
branch
from
5325531 to
e5f7c50
Compare
skyzh
added a commit
that referenced
this pull request
Dec 18, 2024
Signed-off-by: Alex Chi Z <[email protected]>
skyzh
added a commit
that referenced
this pull request
Dec 18, 2024
Signed-off-by: Alex Chi Z <[email protected]>
skyzh
added a commit
that referenced
this pull request
Dec 18, 2024
Signed-off-by: Alex Chi Z <[email protected]>
yliang412
reviewed
Dec 18, 2024
There was a problem hiding this comment.
Reviewed:
- cross join to inner join changes
- main upper bound pruning logic in
optimize_inputs_inner
I need another look at task2.rs and potentially doc more aggressively like https://github.com/cmu-db/optd/pull/234. I actually like this version of the task graph a lot (no state machine logic).
Is there any other part of the logic I need pay special attention to?
|
I think part of this PR is tuning to ensure the plan is what we want (i.e., filter selectivity and behavior on reaching the budget). The tasks2.rs logic is also something that we should fully understand as we are going to bring more logic into it (phys prop, etc.) |
yliang412
approved these changes
Dec 19, 2024
Signed-off-by: Alex Chi Z <[email protected]>
Signed-off-by: Alex Chi Z <[email protected]> tune plan space budget Signed-off-by: Alex Chi Z <[email protected]>
Signed-off-by: Alex Chi Z <[email protected]>
Signed-off-by: Alex Chi Z <[email protected]>
Signed-off-by: Alex Chi Z <[email protected]>
Signed-off-by: Alex Chi Z <[email protected]>
Signed-off-by: Alex Chi Z <[email protected]>
skyzh
force-pushed
the
skyzh/plan-join-perf
branch
from
e5f7c50 to
023d47e
Compare
skyzh
added a commit
that referenced
this pull request
Dec 19, 2024
Signed-off-by: Alex Chi Z <[email protected]>
skyzh
added a commit
that referenced
this pull request
Dec 19, 2024
Signed-off-by: Alex Chi Z <[email protected]> tune plan space budget Signed-off-by: Alex Chi Z <[email protected]>
skyzh
added a commit
that referenced
this pull request
Dec 19, 2024
Signed-off-by: Alex Chi Z <[email protected]>
skyzh
added a commit
that referenced
this pull request
Dec 19, 2024
Signed-off-by: Alex Chi Z <[email protected]>
skyzh
added a commit
that referenced
this pull request
Dec 19, 2024
Signed-off-by: Alex Chi Z <[email protected]>
skyzh
added a commit
that referenced
this pull request
Dec 19, 2024
Signed-off-by: Alex Chi Z <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.